Export the exports of the last actor of a program, if present by nomeata · Pull Request #257 · caffeinelabs/motoko

nomeata · 2019-03-20T11:09:25Z

This finally gives us a way to compile to a WebAssembly module that
exports more than just a start function.

This patch also add the ability to invoke methods from the test suite,
simply by adding lines like

//CALL hello

as seen in hello-world-message.as

Two regressions:

Previously we required programs to have type (), i.e. end with a
unit expression. This is no longer true, and I simply removed the
check (in Pipeline). One could check for “unit or actor” at some
point.
Previously, the test suite would add a
```
print("Top-level code done.\n")
```
to all test cases, to better recognize when the top-level did not go
through. This doesn't work any more, so I just removed it.

crusso

It's a shame we (probably) can express this as simple source to source transformation before compilation.

Also do the interpreter and DFINITY versions of a program still have the same semantics?

crusso · 2019-03-20T11:26:20Z

test/dvm.sh

 dvm_ -q --db $DVM_TMP reset
 dvm_ -q --db $DVM_TMP new $1
 dvm_ -q --db $DVM_TMP run $name start
+


does this let you pass arguments too?

You should add your comments below the interesting lines; the conversation view only shows the marked line and the three lines above…

Yes, it simply dumps whatever follows //CALL onto the shell, and whatever syntax dvm supports for arguments can be used here.

crusso · 2019-03-20T11:30:17Z

src/compile.ml

@@ -4276,6 +4276,11 @@ and compile_start_func env (progs : Ir.prog list) : E.func_with_names =
  Func.of_body env [] [] (fun env1 ->
    let rec go env = function
      | [] -> G.nop


So does this mean that program with no actor has no exports and is just executed for side effects, or not exectured at all?

Executed for side effects, just as before. In fact, every actor has a method called start that contains the side-effects.

nomeata · 2019-03-20T13:56:08Z

It's a shame we (probably) can express this as simple source to source transformation before compilation.

Well, ideally that wouldn't be a transformation, but rather already a source feature, where a .as file only contains type definitions, module definitions, and a single actor, and that would be enforced by the front-end.

Or maybe we want different requirements for module files (contain a single module), actor files (contain a single actor) and programs (contain an expression of type ()), maybe with different file endings?

So yes, there is a cleaner solution out there, but I think it depends on the design for modules and imports.

Also do the interpreter and DFINITY versions of a program still have the same semantics?

Yes and no: The interpreter only executes the top-level, so all the effect of creating a new actor are done. But there is on way of interactively sending a message to the actor then, so we can’t test that there.

This finally gives us a way to compile to a WebAssembly module that exports more than just a `start` function. This patch also add the ability to invoke methods from the test suite, simply by adding lines like //CALL hello as seen in `hello-world-message.as`. This can take additional arguments; they are just dumped into the shell calling `dvm`. Two regressions: * Previously we required programs to have type `()`, i.e. end with a unit expression. This is no longer true, and I simply removed the check (in `Pipeline`). One could check for “unit or actor” at some point. * Previously, the test suite would add a ``` print("Top-level code done.\n") ``` to all test cases, to better recognize when the top-level did not go through. This doesn't work any more, so I just removed it. * If we allow actor expressions in the final expression of a module, we Tests: Conclude type-equivalence and type-inclusion with () have to compile this in type inference mode, which triggers what looks like looping `avoid` (#170). We can work around this with an explicit `()` in the end.

crusso approved these changes Mar 20, 2019

View reviewed changes

nomeata force-pushed the joachim/top-level-actor branch from 61bd1b6 to eb391d1 Compare March 20, 2019 14:00

nomeata merged commit 8b8d482 into master Mar 20, 2019

nomeata deleted the joachim/top-level-actor branch March 20, 2019 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export the exports of the last actor of a program, if present#257

Export the exports of the last actor of a program, if present#257
nomeata merged 1 commit intomasterfrom
joachim/top-level-actor

nomeata commented Mar 20, 2019

Uh oh!

crusso left a comment

Uh oh!

crusso Mar 20, 2019

Uh oh!

nomeata Mar 20, 2019

Uh oh!

crusso Mar 20, 2019

Uh oh!

nomeata Mar 20, 2019

Uh oh!

nomeata commented Mar 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

nomeata commented Mar 20, 2019

Uh oh!

crusso left a comment

Choose a reason for hiding this comment

Uh oh!

crusso Mar 20, 2019

Choose a reason for hiding this comment

Uh oh!

nomeata Mar 20, 2019

Choose a reason for hiding this comment

Uh oh!

crusso Mar 20, 2019

Choose a reason for hiding this comment

Uh oh!

nomeata Mar 20, 2019

Choose a reason for hiding this comment

Uh oh!

nomeata commented Mar 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants